Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪧 Fix slack notification titles #2322

Merged
merged 2 commits into from
Nov 4, 2024
Merged

🪧 Fix slack notification titles #2322

merged 2 commits into from
Nov 4, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Nov 4, 2024

What does this PR do?

For some tests, we don't use matrix. So you can't set the name with, eg, Results with ${{ matrix.python-version }} on ${{ matrix.os }} with dev dependencies
It doesn't fail but renders like this:
Screenshot 2024-11-04 at 20 59 26

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do you mind giving a little more detail in the description about why this is needed?

@qgallouedec
Copy link
Member Author

Thanks, do you mind giving a little more detail in the description about why this is needed?

Done, sorry about that

@qgallouedec qgallouedec merged commit 27b9e3a into main Nov 4, 2024
13 of 14 checks passed
@qgallouedec qgallouedec deleted the fix-title-slack branch November 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants