Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪡 Various RLOO fixes #2325

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Nov 4, 2024

What does this PR do?

Closes #2316

python examples/scripts/rloo/rloo.py
     --dataset_name trl-internal-testing/descriptiveness-sentiment-trl-style
     --dataset_train_split descriptiveness
     --learning_rate 3e-6
     --num_ppo_epochs 1
     --num_mini_batches 1
     --output_dir models/minimal/ppo
     --per_device_train_batch_size 64
     --gradient_accumulation_steps 1
     --total_episodes 10000
     --model_name_or_path EleutherAI/pythia-1b-deduped
     --missing_eos_penalty 1.0
Screenshot 2024-11-04 at 21 13 14

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec linked an issue Nov 4, 2024 that may be closed by this pull request
4 tasks
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec marked this pull request as ready for review November 4, 2024 20:22
@qgallouedec qgallouedec merged commit 9b7f9f3 into main Nov 11, 2024
14 checks passed
@qgallouedec qgallouedec deleted the 2316-several-problems-in-rlootrainer branch November 11, 2024 12:59
@qgallouedec qgallouedec mentioned this pull request Nov 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several problems in RLOOTrainer
3 participants