Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump liger-kernel to 0.4.0 #2333

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Bump liger-kernel to 0.4.0 #2333

merged 2 commits into from
Nov 8, 2024

Conversation

ByronHsu
Copy link
Contributor

@ByronHsu ByronHsu commented Nov 7, 2024

This fixes HF grad acc and other fixes/features/optimizations

@qgallouedec
Copy link
Member

qgallouedec commented Nov 7, 2024

As far as I understand, the grad accum thing is only an issue with SFT right?

@kashif
Copy link
Collaborator

kashif commented Nov 7, 2024

right i think its more about the updated kernels

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ByronHsu
Copy link
Contributor Author

ByronHsu commented Nov 7, 2024

Yes grad accum is only used for sft. Beside grad accum, we also have other improvement

@qgallouedec
Copy link
Member

I approve, as this is an important issue affecting the most widely used trainer. (Thanks for solving it!)

For the record, generally speaking, I won’t raise the minimum version requirement unless a new feature from the dependency is needed in our codebase.

@kashif kashif merged commit c86b51c into huggingface:main Nov 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants