Reduce memory consumption in batched_forward_pass #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces memory consumption in
batched_forward_pass
of PPOTrainer, by avoiding the storage of logits when they are not necessary.Before this PR,
batched_forward_pass
stored all of the model'slogits
all the time like other tensors such asvalues
andlogprobs
. Here,logits
tensors have a much larger size (batch_size * tokens * vocabulary_size) compared tologprobs
andvalues
tensors (batch_size × tokens), consuming a significant amount of cuda memory.I have modified
batched_forward_pass
to avoid unnecessary storage oflogits
, which is only required when calculating entropy in theloss
method.