Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📃 Fix description for parameter "generate_during_eval" in dpo_config #2364

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dakru012
Copy link
Contributor

What does this PR do?

The description of the "generate_during_eval" parameter is incorrectly that of "truncation_mode" in the DPO config.
I aligned it with other similar trainer configs such as BCO or KTO.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…_config. Aligned it with BCO and KTO configs.
@qgallouedec
Copy link
Member

Thanks!

@qgallouedec qgallouedec changed the title Fix description for parameter "generate_during_eval" in dpo_config 📃 Fix description for parameter "generate_during_eval" in dpo_config Nov 18, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 6f8fe59 into huggingface:main Nov 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants