Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality to push best models to the hub during training #275

Merged
merged 6 commits into from
Apr 10, 2023

Conversation

Bearnardd
Copy link
Contributor

@Bearnardd Bearnardd commented Apr 4, 2023

Details

  • update PPOConfig to support arguments for saving models during training
  • update 'PPOTrainer` to support saving models during training
  • add test coverage for the changes

Issue

issue-255

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 5, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I left a single comment
Thanks a lot for working on adding this cool feature!

tests/test_ppo_trainer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@natolambert natolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits / fixes from me.

trl/trainer/ppo_trainer.py Outdated Show resolved Hide resolved
tests/test_ppo_trainer.py Outdated Show resolved Hide resolved
Bearnardd and others added 2 commits April 7, 2023 00:12
Co-authored-by: Nathan Lambert <nathan@huggingface.co>
Co-authored-by: Nathan Lambert <nathan@huggingface.co>
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stil LGTM! Can you run the styling checks?

make style && make quality

trl/trainer/ppo_trainer.py Outdated Show resolved Hide resolved
Bearnardd and others added 2 commits April 7, 2023 14:41
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
@Bearnardd
Copy link
Contributor Author

@younesbelkada Done :)

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your clean work on this!

Copy link
Contributor

@natolambert natolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, excited to use this!

@natolambert natolambert merged commit 131e5cd into huggingface:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants