Skip to content

[NOT MEANT TO BE MERGED] Log correct/incorrect lengths #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qgallouedec wants to merge 4 commits into from
Closed

[NOT MEANT TO BE MERGED] Log correct/incorrect lengths #3263

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27038e9
log correct/incorrect length
qgallouedec Apr 8, 2025
d70f927
Merge branch 'main' into log-correct_incorrect_length
qgallouedec Apr 8, 2025
1696a5e
Merge branch 'main' into log-correct_incorrect_length
qgallouedec Apr 8, 2025
c283425
Merge branch 'main' into log-correct_incorrect_length
qgallouedec Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions trl/trainer/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,19 @@ def _generate_and_score_completions(
self._metrics[mode]["reward"].append(mean_grouped_rewards.mean().item())
self._metrics[mode]["reward_std"].append(std_grouped_rewards.mean().item())

# Get the length of the completions for "accuracy_reward" function
if "accuracy_reward" in reward_func_names:
accuracy_reward_idx = reward_func_names.index("accuracy_reward")
accuracy_reward = rewards_per_func[:, accuracy_reward_idx]

length_correct = agg_completion_mask[accuracy_reward == 1.0].float().nanmean()
if not torch.isnan(length_correct):
self._metrics[mode]["length_correct"].append(length_correct.item())

length_incorrect = agg_completion_mask[accuracy_reward == 0.0].float().nanmean()
if not torch.isnan(length_incorrect):
self._metrics[mode]["length_incorrect"].append(length_incorrect.item())

# Log prompt and completion texts
self._textual_logs["prompt"].extend(gather_object(prompts_text))
self._textual_logs["completion"].extend(gather_object(completions_text))
Expand Down