Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autotag feature w/ wandb #411

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Conversation

vwxyzjn
Copy link
Contributor

@vwxyzjn vwxyzjn commented Jun 7, 2023

This PR automatically tags the wandb experiments with the git tags and PR number if possible.

image

The tag will be helpful later on for RLops for which we compare the performance of some sanity check tasks between different. versions of the library.

image

@vwxyzjn vwxyzjn marked this pull request as ready for review June 7, 2023 15:33
@vwxyzjn
Copy link
Contributor Author

vwxyzjn commented Jun 7, 2023

I put the feature in PPOConfig which might not be the best place... Would you recommend putting it anywhere else? We just need to run the tagging feature before wandb.init

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me ! Amazing feature 🚀
I think placing it on the PPOConfig is good, I think we should remove the prints (and ideally replace them with a warnings or logging.info message but it can be done later I think) wdyt?

@vwxyzjn
Copy link
Contributor Author

vwxyzjn commented Jun 7, 2023

@younesbelkada thanks for the review! I have put them under logging.info.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature! Thanks a lot for adding this @vwxyzjn ! 🎉
Left one suggestion, otherwise LGTM

trl/trainer/ppo_config.py Outdated Show resolved Hide resolved
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
@vwxyzjn vwxyzjn changed the title Enable autotag feature Enable autotag feature w/ wandb Jun 7, 2023
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this should fix the failing CI !

trl/trainer/ppo_config.py Outdated Show resolved Hide resolved
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
@younesbelkada younesbelkada requested a review from lvwerra June 7, 2023 16:25
@vwxyzjn vwxyzjn mentioned this pull request Jun 7, 2023
@lvwerra lvwerra merged commit 216c119 into huggingface:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants