-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable autotag feature w/ wandb #411
Conversation
I put the feature in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me ! Amazing feature 🚀
I think placing it on the PPOConfig
is good, I think we should remove the prints (and ideally replace them with a warnings
or logging.info
message but it can be done later I think) wdyt?
@younesbelkada thanks for the review! I have put them under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature! Thanks a lot for adding this @vwxyzjn ! 🎉
Left one suggestion, otherwise LGTM
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this should fix the failing CI !
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
This PR automatically tags the wandb experiments with the git tags and PR number if possible.
The tag will be helpful later on for RLops for which we compare the performance of some sanity check tasks between different. versions of the library.