Skip to content

CI hotfix: xfail test_training_with_transformers_paged for transformers<4.57.0 #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

CI hotfix: xfail test_training_with_transformers_paged for transformers<4.57.0 #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/slow/test_grpo_slow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ def test_training_with_liger_grpo_loss_and_peft(self, model_name):
@parameterized.expand(MODELS_TO_TEST)
def test_training_with_transformers_paged(self, model_name):
"""Test that training works with transformers paged implementation (requires GPU)."""
if Version(transformers.__version__) < Version("4.56.2"):
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.56.2")
if Version(transformers.__version__) < Version("4.57.0"):
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0")
training_args = GRPOConfig(
output_dir=self.tmp_dir,
learning_rate=0.1, # increase the learning rate to speed up the test
Expand Down
4 changes: 2 additions & 2 deletions tests/test_online_dpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,8 @@ def test_generation_config_setup(self):
@require_torch_accelerator
@parameterized.expand([("standard_prompt_only",), ("conversational_prompt_only",)])
def test_training_with_transformers_paged(self, config_name):
if Version(transformers.__version__) < Version("4.56.2"):
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.56.2")
if Version(transformers.__version__) < Version("4.57.0"):
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0")
training_args = OnlineDPOConfig(
output_dir=self.tmp_dir,
per_device_train_batch_size=2,
Expand Down
Loading