Skip to content

[vllm] update comment about communication group host ip #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
+2 −1
Merged

[vllm] update comment about communication group host ip #4337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d0ab5
Change host address to use self.host variable
kashif Oct 24, 2025
b9e53e6
Change host to '0.0.0.0' for weight updates
kashif Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion trl/extras/vllm_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,8 @@ def init_communicator(self, device: Union[torch.device, str, int] = 0):
else:
client_device_uuid = str(torch.cuda.get_device_properties(device).uuid)

# In the server side, the host is set to 0.0.0.0
# Set the weight update group's host to "0.0.0.0" so that
# clients from different IPs can send updated weights
response = self.session.post(
url,
json={
Expand Down
Loading