Skip to content

Conversation

@Harras3
Copy link
Contributor

@Harras3 Harras3 commented Nov 2, 2025

What does this PR do?

Removed Sentiment Tuning Examples and there links from docs.

Fixes #4396
#4396

Files Edited

docs/source/example_overview.md
examples/notebooks/README.md

Files Removed

examples/notebooks/gpt2-sentiment-control.ipynb
examples/notebooks/gpt2-sentiment.ipynb
docs/source/sentiment_tuning.md

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@qgallouedec
Copy link
Member

thanks, you also need to remove sentiment_tuning from trl/docs/source/_toctree.yml

@Harras3 Harras3 requested a review from qgallouedec November 3, 2025 15:46
@Harras3
Copy link
Contributor Author

Harras3 commented Nov 3, 2025

thanks, you also need to remove sentiment_tuning from trl/docs/source/_toctree.yml

Yes thanks. Removed it kindly approve this again.

@Harras3 Harras3 closed this Nov 4, 2025
@Harras3 Harras3 reopened this Nov 4, 2025
@Harras3
Copy link
Contributor Author

Harras3 commented Nov 4, 2025

@qgallouedec Kindly approve this again.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 4677cf2 into huggingface:main Nov 4, 2025
1 check passed
qgallouedec added a commit that referenced this pull request Nov 4, 2025
commit 4677cf2
Author: Harras Mansoor <98635627+Harras3@users.noreply.github.com>
Date:   Wed Nov 5 04:06:13 2025 +0500

    Removed Sentiment Tuning Examples (#4424)

commit 7a9592b
Author: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Date:   Tue Nov 4 14:32:04 2025 -0700

    🐍 Drop Python 3.9 (#4183)

commit 7f15a7f
Author: Harras Mansoor <98635627+Harras3@users.noreply.github.com>
Date:   Wed Nov 5 02:06:31 2025 +0500

    Removed outdated warning about batch contamination (#4423)

commit 8b0a3ce
Author: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
Date:   Tue Nov 4 21:37:39 2025 +0100

    Update tokenizer apply_chat_template with return_dict=True default (#4448)

commit d9f9e2b
Author: Pramodith Ballapuram <16939722+pramodith@users.noreply.github.com>
Date:   Tue Nov 4 19:56:58 2025 +0000

    Support casting to fp32 when word embeddings are tied to lm_head (#4446)

commit 4e138ab
Author: Sergio Paniego Blanco <sergiopaniegoblanco@gmail.com>
Date:   Tue Nov 4 15:15:23 2025 +0100

    Upload notebook with T4 selected (#4449)

commit 43253b2
Author: Pramodith Ballapuram <16939722+pramodith@users.noreply.github.com>
Date:   Mon Nov 3 21:07:31 2025 +0000

    Add On-Policy Distillation from thinking labs to paper index. (#4410)

    Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>

commit 6f41b18
Author: Behrooz Azarkhalili <80390531+behroozazarkhalili@users.noreply.github.com>
Date:   Mon Nov 3 10:57:51 2025 -0800

    fix: Remove chat template setting from non-SFT trainer scripts (#4437)

    Co-authored-by: Quentin Gallouédec <gallouedec.quentin@gmail.com>
    Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Sentiment Tuning Examples

3 participants