Skip to content

Consistency regarding relative imports #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2025
Merged

Consistency regarding relative imports #4498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baa0b06
consistency: relative imports
qgallouedec Nov 6, 2025
a02b260
Merge branch 'main' into relative-imports
qgallouedec Nov 7, 2025
6c1ecdc
Merge branch 'main' into relative-imports
qgallouedec Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trl/experimental/grpo_with_replay_buffer/grpo_with_replay_buffer_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from dataclasses import dataclass, field

from trl.trainer.grpo_config import GRPOConfig
from ...trainer.grpo_config import GRPOConfig


@dataclass
Expand Down
11 changes: 3 additions & 8 deletions trl/experimental/grpo_with_replay_buffer/grpo_with_replay_buffer_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,9 @@
import torch
from accelerate.utils import gather_object

from trl.data_utils import (
apply_chat_template,
is_conversational,
prepare_multimodal_messages,
)
from trl.trainer.grpo_trainer import GRPOTrainer
from trl.trainer.utils import nanmax, nanmin, nanstd, pad

from ...data_utils import apply_chat_template, is_conversational, prepare_multimodal_messages
from ...trainer.grpo_trainer import GRPOTrainer
from ...trainer.utils import nanmax, nanmin, nanstd, pad
from .grpo_with_replay_buffer_config import GRPOWithReplayBufferConfig


Expand Down
3 changes: 1 addition & 2 deletions trl/experimental/gspo_token/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@

import torch

from trl import GRPOTrainer as _GRPOTrainer

from ...trainer.grpo_trainer import GRPOTrainer as _GRPOTrainer
from ...trainer.utils import nanmax, nanmin


Expand Down
2 changes: 1 addition & 1 deletion trl/mergekit_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import torch
from huggingface_hub import HfApi

from trl.import_utils import is_mergekit_available
from .import_utils import is_mergekit_available


if is_mergekit_available():
Expand Down
2 changes: 1 addition & 1 deletion trl/rewards/accuracy_rewards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from trl.import_utils import is_math_verify_available
from ..import_utils import is_math_verify_available


if is_math_verify_available():
Expand Down
2 changes: 1 addition & 1 deletion trl/trainer/nash_md_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from dataclasses import dataclass, field

from trl.trainer.online_dpo_config import OnlineDPOConfig
from .online_dpo_config import OnlineDPOConfig


@dataclass
Expand Down
Loading