Debug the tortuous logic in _prepare_dataset function
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two issues with the previous `_prepare_dataset` function. 1. Tortuous and burdensome logic: the `is_already_dataset` variable is confusing and not helpful. So, remove it. 2. The comments and the logics do not match. For instance, in the previous version, the comments said "check if torch dataset ... and do nothing". However, when "dataset" is a torch.utils.data.Dataset and `packing = True`? It will still move into the _prepare_non_packed_dataloader(...) function call. The corrected version will do nothing if the dataset is already a torch dataloader/dataset/ConstantLengthDataset.
|
The documentation is not available anymore as the PR was closed or merged. |
Thanks! I just re-ran the styling checks and pushed the latest code. |
younesbelkada
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with the previous
_prepare_datasetfunction.is_already_datasetvariable is confusing and not helpful. So, remove it.For instance, in the previous version, the comments said "check if torch dataset ... and do nothing". However, when "dataset" is a torch.utils.data.Dataset and
packing = True? It will still move into the _prepare_non_packed_dataloader(...) function call.The corrected version will do nothing if the dataset is already a torch dataloader/dataset/ConstantLengthDataset.