Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RuntimeError: 'weight' must be 2-D issue #687

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix: RuntimeError: 'weight' must be 2-D issue #687

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb6507
Update dpo_trainer.py
jp1924 Aug 24, 2023
4b5e45b
Fix: self.args.deepspeed > self.is_deepspeed_enabled
jp1924 Aug 31, 2023
412f8fb
Update trl/trainer/dpo_trainer.py
jp1924 Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion trl/trainer/dpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,12 @@ def __init__(
"You are using a `peft` version that does not support `disable_adapter`. Please update your `peft` version to the latest version."
)
else:
self.ref_model = self.accelerator.prepare_model(self.ref_model, evaluation_mode=True)
if self.is_deepspeed_enabled:
# Read more about the issue in https://github.com/huggingface/trl/pull/687
self.ref_model = self.accelerator._prepare_deepspeed(self.ref_model)
self.ref_model.eval()
else:
self.ref_model = self.accelerator.prepare_model(self.ref_model, evaluation_mode=True)

def concatenated_inputs(self, batch: Dict[str, Union[List, torch.LongTensor]]) -> Dict[str, torch.LongTensor]:
"""Concatenate the chosen and rejected inputs into a single tensor.
Expand Down