Use uniform config #817
Merged
Use uniform config #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Thanks a lot @vwxyzjn - LGTM! I'll also let @younesbelkada have a look :)
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Use uniform config * quick fix * refactor * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts various configs to the new format. Things should be backward-compatible at this PR.
I did not refactor
stable_diffusion_tuning.pynorreward_trainer.pybecause that refactor might involve documentation changes. We should do them in separate PRs. For example, we would probably dopython stable_diffusion_tuning.py --ddpo_config.train_batch_size 32instead ofpython stable_diffusion_tuning.py --train_batch_size 32. Let's probably do them in separate PRs.