Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set trust remote code to false by default #833

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Set trust remote code to false by default #833

merged 1 commit into from
Oct 4, 2023

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Oct 4, 2023

In the maintained examples, trust_remote_code is set to True by default which means they cannot be run with the Falcon models due to the existence of custom modelling code in the model repos (takes precedence over transformers modelling code).

This PR sets it to False by default, which is also the default in transformers

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 4, 2023

The documentation is not available anymore as the PR was closed or merged.

@lewtun lewtun merged commit fbeb146 into main Oct 4, 2023
@lewtun lewtun deleted the tweak-sft-args branch October 4, 2023 20:53
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants