Support both old and new diffusers import path #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
younesbelkada
approved these changes
Oct 11, 2023
|
Note the lazy import has been added in 0.21.0 and the latest version before that is 0.20.2 https://github.com/huggingface/diffusers/releases/tag/v0.21.0 |
lvwerra
reviewed
Oct 12, 2023
trl/models/modeling_sd_base.py
Outdated
Comment on lines
31
to
34
| if is_diffusers_greater_than("0.20.2"): | ||
| from diffusers.utils.torch_utils import randn_tensor | ||
| else: | ||
| from diffusers.utils import randn_tensor |
There was a problem hiding this comment.
If I understood Patrick correctly, randn_tensor is an internal method that could be deprecated, delete, renamed at any time. Should we not use it and instead add our own?
lvwerra
reviewed
Oct 12, 2023
trl/torch_utils.py
Outdated
lvwerra
approved these changes
Oct 12, 2023
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Update modeling_sd_base.py * Update trl/models/modeling_sd_base.py Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> * make precommit * cleaner approach * oops * better alternative * rm uneeded file --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Co-authored-by: younesbelkada <younesbelkada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.