Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate key in reward_modeling.py #890

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove duplicate key in reward_modeling.py #890

merged 1 commit into from
Oct 18, 2023

Conversation

vwxyzjn
Copy link
Contributor

@vwxyzjn vwxyzjn commented Oct 18, 2023

To make reward_modeling.py runnable again

younesbelkada
younesbelkada approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks!

@younesbelkada younesbelkada merged commit f91fb2b into huggingface:main Oct 18, 2023
2 of 11 checks passed
kashif pushed a commit to kashif/trl that referenced this pull request Oct 27, 2023
@vwxyzjn @kashif
remove duplicate key in reward_modeling.py (huggingface#890)
441ef98
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@vwxyzjn
remove duplicate key in reward_modeling.py (huggingface#890)
6b2e5b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwxyzjn @younesbelkada