-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Improve docs #91
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a few small comments. Also fortrain_minibatch
: we could make the docstring a bit better: "Train the model for PPO mini-batch."
docs/source/trainer.mdx
Outdated
@@ -0,0 +1,12 @@ | |||
# Trainer | |||
|
|||
At TRL we plan to release several RLHF algorithms, we started our journey with PPO (Proximal Policy Optimisation) with an implementation that largely follows the structure introduced in the paper "Fine-Tuning Language Models from Human Preferences" by D. Ziegler et al. [[paper](https://arxiv.org/pdf/1909.08593.pdf), [code](https://github.com/openai/lm-human-preferences)]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since adding new algorithms is not on the roadmap at the moment maybe let's just focus on PPO :)
We could also add a sentence or two about the classes. E.g. that they are inspired/influence by the transformers.Trainer
and are adapted to RL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Adapted the text in da456cf
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Add the following on the documentation
API
AutoModelForCausalLMWithValueHead
&PreTrainedModelWrapper
)PPOTrainer
&PPOConfig
)