Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom EncoderDecoder models #911

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

ribesstefano
Copy link
Contributor

@ribesstefano ribesstefano commented Oct 24, 2023

Resolving issue #670.

Fixes #670

@lvwerra lvwerra requested a review from younesbelkada October 24, 2023 12:31
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@younesbelkada
Copy link
Contributor

Actually let's wait for the CI to be green before merging

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lvwerra
Copy link
Member

lvwerra commented Oct 31, 2023

Can you merge main into your branch? We fixed the flaky tests in the CI.

@younesbelkada younesbelkada merged commit 654543a into huggingface:main Nov 6, 2023
8 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while loading a pretrained EncoderDecoder model
4 participants