[SFTTrainer] Make sure to not conflict between transformers and TRL implementation
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvwerra
approved these changes
Oct 31, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…RL implementation (huggingface#933) * standardize neftune * up * fix again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, huggingface/transformers#27141 is going to be merged in transformers, therefore this PR makes sure
SFTTrainer's NEFTune does not conflict with transformers Trainer onecc @lvwerra