Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DPOTrainer + PEFT #941

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix DPOTrainer + PEFT #941

merged 1 commit into from
Nov 2, 2023

Conversation

younesbelkada
Copy link
Contributor

Fixes #877

Indeed as stated in the issue when using PeftModel and call generate you need to pass explicit positional arguments otherwise generate will fail

cc @lvwerra

@younesbelkada younesbelkada requested a review from lvwerra November 1, 2023 21:29
@younesbelkada younesbelkada mentioned this pull request Nov 1, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 1, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lewtun
lewtun approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@younesbelkada younesbelkada merged commit a64a522 into main Nov 2, 2023
8 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch November 2, 2023 10:27
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@younesbelkada
Update dpo_trainer.py (huggingface#941)
1e120b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun approved these changes

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong invocation of PeftModelForCausalLM.generate in DPOTrainer?
4 participants
@younesbelkada @HuggingFaceDocBuilderDev @lvwerra @lewtun