[DPO] Merge initial peft model if trainer has a peft_config #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shoaib Burq <saburq@gmail.com>
|
The documentation is not available anymore as the PR was closed or merged. |
|
@Elfsong can you check if i am testing the failure case you have in the test? |
I’m currently working on this demo FYI: |
younesbelkada
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM - given that this is a common scenario (people can SFT their model with peft and use that model for DPO) ! Thanks @kashif !
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…ace#956) * failing test Co-authored-by: Shoaib Burq <saburq@gmail.com> * merge initial peft model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #742
We merge the initial peft adaptor if we are training with a peft_config