Skip to content

Commit

Permalink
Only use config server if env var unset (open-telemetry#1728)
Browse files Browse the repository at this point in the history
  • Loading branch information
rmfitzpatrick authored Jun 24, 2022
1 parent 6e63638 commit 0adc731
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ In addition, the following components can be configured:
- Information about migrating from the SignalFx Smart Agent can be found
[here](docs/signalfx-smart-agent-migration.md)

By default the Splunk OpenTelemetry Collector provides a sensitive value-redacting, local config server listening at
`http://localhost:55554/debug/configz/effective` that is helpful in troubleshooting. To disable this feature please
set the `SPLUNK_DEBUG_CONFIG_SERVER` environment variable to any value other than `true`. To set the desired port to
listen to configure the `SPLUNK_DEBUG_CONFIG_SERVER_PORT` environment variable.

## Upgrade guidelines

The following changes need to be done to configuration files for Splunk OTel Collector for specific
Expand Down
4 changes: 3 additions & 1 deletion cmd/otelcol/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ func main() {

// Allow dumping configuration locally by default
// Used by support bundle script
_ = os.Setenv(configServerEnabledEnvVar, "true")
if _, ok := os.LookupEnv(configServerEnabledEnvVar); !ok {
_ = os.Setenv(configServerEnabledEnvVar, "true")
}

factories, err := components.Get()
if err != nil {
Expand Down

0 comments on commit 0adc731

Please sign in to comment.