Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installed tests fail #19

Closed
jtojnar opened this issue Mar 30, 2020 · 0 comments · Fixed by #20
Closed

Installed tests fail #19

jtojnar opened this issue Mar 30, 2020 · 0 comments · Fixed by #20

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Mar 30, 2020 

Jcat:ERROR:../libjcat/jcat-self-test.c:221:jcat_sha1_engine_func: assertion failed (error == NULL): Failed to open file ?/build/source/data/tests/colorhug/firmware.bin?: No such file or directory (g-file-error-quark, 4)
Bail out! Jcat:ERROR:../libjcat/jcat-self-test.c:221:jcat_sha1_engine_func: assertion failed (error == NULL): Failed to open file ?/build/source/data/tests/colorhug/firmware.bin?: No such file or directory (g-file-error-quark, 4)
@jtojnar jtojnar mentioned this issue Mar 30, 2020
Merged
10 tasks
hughsie added a commit that referenced this issue Mar 30, 2020
@hughsie
Make the installed tests actually work
2b6c4db 
If the source or build directory is not available then it currently fails,
which isn't the idea of installed tests at all...

Also, as we're here, make the build 100% reproducable by sharing the build dir
as an environment variable to the local tests rather than a cflag.

To run the installed tests users can use:

    gnome-desktop-testing-runner libjcat/libjcat.test

Fixes #19
@hughsie hughsie mentioned this issue Mar 30, 2020
Merged
hughsie added a commit that referenced this issue Mar 30, 2020
@hughsie
Make the installed tests actually work
d6dc3e9 
If the source or build directory is not available then it currently fails,
which isn't the idea of installed tests at all...

Also, as we're here, make the build 100% reproducable by sharing the build dir
as an environment variable to the local tests rather than a cflag.

To run the installed tests users can use:

    gnome-desktop-testing-runner libjcat/libjcat.test

Fixes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the installed tests actually work hughsie/libjcat
1 participant
@jtojnar