Hughsie/win32 #177
Merged
Hughsie/win32 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
To do this, remove the 'cached' silo from the builder -- which allows us to drop the mmap to the existing silo before writing the new one. This works around a regression in GLib, which started calling `_chsize()` during `g_file_set_contents_full()` -- which doesn't work when the thing we're trying to truncate is `mmap`'d. It's probably dumb to *not* unmap the previous file before writing the new one -- although unmapping and then re-mapping the file was the first thing libxmlb did after writing the file. That's 6 hours of my life I'm never going to get back, although it does make the builder slightly simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.