Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python>3.9 #15

Closed
orrp opened this issue Aug 14, 2023 · 2 comments
Closed

Remove support for Python>3.9 #15

orrp opened this issue Aug 14, 2023 · 2 comments

Comments

@orrp
Copy link

orrp commented Aug 14, 2023

Currently, the readme states that setup requires Python 3.9 or later. But Python 3.10 onwards is currently not supported: The user encounters ImportError: cannot import name 'MutableSequence' from 'collections' if running on Python 3.10. This is because of a known issue with madmom. Until that's fixed, I suggest changing the readme to say that Python==3.9 is required.

@hugofloresgarcia
Copy link
Owner

updated the readme. thanks for that!

@tig3rmast3r
Copy link

tig3rmast3r commented Sep 16, 2023

it works here with python 3.11.4 on windows 10
you have to install madmom from source to get v0.17.dev0 where it has been fixed already
also numpy needs to be 1.23 at least on my machine
you may need to modify the file mask.py on line 197 too as described here #12 i think is a Windows only issue

(base) PS C:\Users\xxxxx\documents\vampnet\vampnet> python --version
Python 3.11.4
(base) PS C:\Users\xxxxx\documents\vampnet\vampnet> pip show numpy | findstr "Version"
Version: 1.23.0
(base) PS C:\Users\xxxxx\documents\vampnet\vampnet> pip show madmom | findstr "Version"
Version: 0.17.dev0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants