Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ue): open result on new tab when on single search page mode #270

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat(ue): open result on new tab when on single search page mode #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/search/js/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { init as i18nInit } from "./i18n"
new Search()

if (params.modal_container !== '') {
(new Modal()).init()
(new Modal()).init()
}
})
})
Expand Down
15 changes: 13 additions & 2 deletions assets/search/js/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,24 @@ export default class Renderer {

}

private resultLinkTarget = ''

private getResultLinkTarget(): string {
if (this.resultLinkTarget === '' && this.getContainer().closest('.search-container') !== null) {
// open result on new tab on single search page mode.
this.resultLinkTarget = ' target="_blank"'
}

return this.resultLinkTarget
}

private renderPage(page = 1) {
const max = page * this.paginate
const min = max - this.paginate
let results = ''
for (let i = min; i < this.results.length && i < max; i++) {
const result = this.results[i]
results += `<a title="${result.item.title}" href="${this.url(result.item, result.item.url)}" class="search-result" aria-selected="false">
results += `<a title="${result.item.title}" href="${this.url(result.item, result.item.url)}"${this.getResultLinkTarget()} class="search-result" aria-selected="false">
<div class="search-result-icon">${this.icon(result.item)}</div>
<div class="search-result-content">
<div class="search-result-title">${this.title(result)}</div>
Expand Down Expand Up @@ -377,7 +388,7 @@ export default class Renderer {
ancestors = ancestors.concat(result.item.title)
const subtitle = ancestors.join(' · ')

headings += `<a title="${heading.title} - ${subtitle}" href="${this.url(result.item, result.item.url)}#${heading.anchor}" class="search-result search-result-heading">
headings += `<a title="${heading.title} - ${subtitle}" href="${this.url(result.item, result.item.url)}#${heading.anchor}"${this.getResultLinkTarget()} class="search-result search-result-heading">
<div class="search-result-icon search-result-heading-icon">${params.icons['heading']}</div>
<div class="search-result-content">
<div class="search-result-title">${this.highlight(heading.title, [matches[j]])}</div>
Expand Down
Loading