Add better guard against location definition #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2021
hugomrdias
requested changes
Feb 23, 2021
acostalima
force-pushed
the
fix/better-guard-against-location
branch
8 times, most recently
from
dd7102e to
005b9f3
Compare
acostalima
force-pushed
the
fix/better-guard-against-location
branch
from
005b9f3 to
be8c037
Compare
|
@hugomrdias I'm not sure whether I've messed up |
|
can we add the RN test runner to the ci ? |
I thought about this today as well, haha. Sure, I think it makes sense! |
|
@hugomrdias can we merge this anyway to unblock ipfs/js-ipfs-utils#91? I'll add RN test runner tomorrow in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I've run across a situation in a React Native environment where
locationwas defined butlocation.hostandlocation.protocolwere not. The changes I propose herein defend the code better in such situation.I've also took the opportunity to replace
selfwithglobalThisusingglobalthisshim.