Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
  • Loading branch information
hugovk and ezio-melotti authored Jul 9, 2024
1 parent b1e43ca commit b7f6da0
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions docs/monthly-meeting/2024-07.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Please take a second to read through it!
(Name / `@GitHubUsername` *[/ Discord, if different]*)

- Daniele Procida `@danieleprocida`
- Carol
- Carol / `@willingc`
- Ned Batchelder / `@nedbat`
- Ezio Melotti / `@ezio-melotti`
- Petr Viktorin / `@encukou`
Expand Down Expand Up @@ -79,16 +79,16 @@ Please take a second to read through it!

- [Ryan] I need to load JSON with NaN values.
[The official documentation](https://docs.python.org/3/library/json.html#json.load) says:
***parse_constant**, if specified, will be called with one of the following strings:
'-Infinity', 'Infinity', 'NaN'. This can be used to raise an exception if
invalid JSON numbers are encountered.*
> **parse_constant**, if specified, will be called with one of the following strings:
> `'-Infinity'`, `'Infinity'`, `'NaN'`. This can be used to raise an exception if
invalid JSON numbers are encountered.
- I could not tell how to use this, or even if it is what I needed, until I
Googled it and
[found this example on Stack Overflow](https://stackoverflow.com/a/62685520).
- As a user, I intend to open a thread on Discourse before making a PR. But
is there a more open conversation we should have about examples within
documentation for docs.python.org, first?
- You don't need a discussion; file an issue and send a PR.
- You don't need a discussion; file an issue and send a PR.

- [Hugo] Re: avoiding duplicate deprecations across What's New files:
[Discourse](https://discuss.python.org/t/streamline-whats-new-by-moving-deprecations-and-removals-out-of-news/53997)
Expand All @@ -104,6 +104,7 @@ Please take a second to read through it!
- What needs EB pronouncement
- Can we help people understand terse punctuation?
- add a tooltip? That won't work on mobile & screen readers
- still better than nothing for non-mobile users
- make it a link?
- first make sure there's a good place to link to
- make sure [searching for `/`](https://docs.python.org/3/search.html?q=%2F)
Expand Down

0 comments on commit b7f6da0

Please sign in to comment.