Remove needless import itertools and iterator complexity
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 95.69% 95.58% -0.11%
==========================================
Files 2 2
Lines 209 204 -5
==========================================
- Hits 200 195 -5
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hukkin
commented
Jan 20, 2025
|
|
||
| if None in results: | ||
| no_copy = True | ||
| missing = True | ||
| results = (r for r in results if r) | ||
| results = tuple(r for r in results if r) |
There was a problem hiding this comment.
This currently works as a generator too, but seems a bit dangerous. The generator is used twice in the code that follows, so on the second time (i.e. results = "".join(results)) it will be empty. Luckily in that case the value results is always unused. So it works, but just barely ;)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionally this shouldn't change anything.