Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary emoji database copy from wheel and sdist #163

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Jan 20, 2025

It seems that emoji-en-US.json is a temporary file, mostly a copy of the final despacified emojis.json so perhaps better to leave it out of the wheel and sdist?

This roughly halves the size of wheels built with pipx run build.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (81cf3de) to head (0e8212e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files           2        2           
  Lines         203      203           
=======================================
  Hits          194      194           
  Misses          9        9           
Flag Coverage Δ
macos-latest 92.61% <ø> (ø)
ubuntu-latest 93.10% <ø> (ø)
windows-latest 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hukkin hukkin force-pushed the no-duplicate-emoji-db branch from cb47a5f to 0e8212e Compare January 20, 2025 15:39
@hugovk hugovk added the changelog: Changed For changes in existing functionality label Jan 20, 2025
@hugovk
Copy link
Owner

hugovk commented Jan 20, 2025

Thanks!

Noting this reduced the whl from 105 KM to 54 KB, and the tar.gz from 112 KB to 62 KB.

@hugovk hugovk merged commit 6eb4993 into hugovk:main Jan 20, 2025
29 of 30 checks passed
@hukkin hukkin deleted the no-duplicate-emoji-db branch January 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants