Drop Python 3.6 and add some type hints #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to drop 3.6 to use
from __future__ import annotations
. Could use 3.6 compatible things likefrom typing import Tuple, Union
, but 3.6 is soon EOL:And has lowest of the (quite low anyway) pip installs from PyPI for September 2021:
Source:
pip install -U pypistats && pypistats python_minor pypistats --last-month
Plus refactor some tests to use
pytest.mark.parametrize
and addpytest.param(..., id=...)
to make nicer verbose output.