Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] Fix find_libc_version for checking each readable maps #1110

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

ValekoZ
Copy link
Collaborator

@ValekoZ ValekoZ commented May 29, 2024

On a 2.30 libc, the string glibc 2.30 was on a r-x page instead of a r-- page.
Checking all readable pages would not affect performances too much since it is unlikely to have lots of libc maps, and this function is not called often.

Copy link

🤖 Coverage update for 786fc36 🔴

Old New
Commit 757f5bb 786fc36
Score 71.5302% 71.4923% (-0.0379)

@hugsy hugsy added this to the 2024.06 milestone Jun 2, 2024
@hugsy hugsy merged commit ff185e6 into hugsy:main Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants