Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly improves #579: instead of hardcoding some addresses which would not work on non 64b archs, we completely assumes that the debugged binary is emulated by qemu and therefore show the qemu mem maping. This allows for a clean and effective way to have the correct page permissions set in gef (and might help oneself who tries to escape the qemu process 😃 )
The reasoning behind is mostly that when debugging we don't really care that it's qemu-emulated, and have a proper memory mapping is just that much more useful info.
Before
![image](https://user-images.githubusercontent.com/590234/114228705-b4268980-992b-11eb-8429-58601dd75cf3.png)
![image](https://user-images.githubusercontent.com/590234/114228754-c4d6ff80-992b-11eb-9860-90afe3cd5e17.png)
After
![image](https://user-images.githubusercontent.com/590234/114228802-d7513900-992b-11eb-8718-84996a6956e0.png)
![image](https://user-images.githubusercontent.com/590234/114228827-e0420a80-992b-11eb-9aaf-01829701fb04.png)
How Has This Been Tested?
make tests
Checklist
dev
branch, notmaster
.