Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add missing commas in list #811

Closed
wants to merge 1 commit into from

Conversation

daniellimws
Copy link
Collaborator

@daniellimws daniellimws commented Jan 31, 2022

tests: add missing commas in list

This is a cleaned up version of #808. I tried to rebase that branch to better_tests but maybe because of some forced pushes it doesn't rebase properly with the correct changes.

Thanks to @mrshu for the find. If the original PR is cleaned up then we can merge that one instead.

@hugsy
Copy link
Owner

hugsy commented Jan 31, 2022

Hey,

I've already fixed this issue locally because:

  1. this list in test is incomplete
  2. this list in test is incorrect

I will push soon with more changes.

Thanks,

@hugsy hugsy closed this Jan 31, 2022
@hugsy hugsy deleted the theme-test-add-commas branch January 31, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants