DNS support broken

[dcode]

When configuring an IPA master server and configuring DNS, the installation fails (and gets to a pretty annoying state, honestly).

My config:

node 'ds.example.lan' {
    class { 'ipa' :
        master  => true,
        domain  => 'example.lan',
        realm   => 'EXAMPLE.LAN',
        adminpw => '<ADMINPW>',
        dspw    => '<DSPW>',
        dns     => true,
        ntp     => true,
        sudo    => true
    }
}

Running puppet apply ipa-master.pp does the normal thing, installing the necessary packages, but when /usr/sbin/ipa-server-install is run from 'serverinstall.pp', the shellescape function quotes the following from $dnsopt: "--setup-dns --no-forwarders". Since it is quoted, ipa-server-install treats this as a single parameter and fails.

I temporarily worked around this by replacing the shellescape with just a join from stdlib, but it might be better to pass all these "nested" parameters as nested lists and then call flatten just inside the shellescape.

Once I got the setup script to run correctly, it actually failed because openldap was already running from the failed attempts. I had to remove it (which "cleanup => true" didn't handle, though that is understandable) and kill the slapd processes. Then it worked like a champ.

[robruma]

Thanks for the bug report. Would you mind submitting a pull request of your DNS options handling method? Also, was it the 389 dirsrv config that wasn't removed or related processes/packages?

[dcode]

The 389 dirsrv processes were still running. I'll make the patch and submit
a pull request.
On Feb 17, 2014 6:02 AM, "Rob Ruma" notifications@github.com wrote:

Thanks for the bug report. Would you mind submitting a pull request of
your DNS options handling method? Also, was it the 389 dirsrv config that
wasn't removed or related processes/packages?

Reply to this email directly or view it on GitHubhttps://github.com//issues/33#issuecomment-35250962
.

[dcode]

Hmm....when I ran against the master branch as of today, everything seemed to work. Using the 'puppet module install' method didn't work, however. I've got another go at this, so I'll clarify and make sure nothing crazy happened.

[robruma]

That kinda makes sense... We haven't fully vetted the new changes in master so I haven't released a new version to the forge. Once we're sure the changes in master work in all cases, I'll submit a new forge release.

Thanks
Rob

[robruma]

dcode,
Can you try the current master branch to see if the new changes fixed the issue you were having?

Thanks
Rob

[dcode]

I'll try to give it a whirl sometime this week.

On Tue, Mar 25, 2014 at 8:42 PM, Rob Ruma notifications@github.com wrote:

dcode,
Can you try the current master branch to see if the new changes fixed the
issue you were having?

Thanks
Rob

Reply to this email directly or view it on GitHubhttps://github.com//issues/33#issuecomment-38642015
.