Update gitService.ts to use spawn instead of exec#88
Merged
huizhougit merged 1 commit intohuizhougit:masterfrom Aug 2, 2024
Merged
Update gitService.ts to use spawn instead of exec#88huizhougit merged 1 commit intohuizhougit:masterfrom
huizhougit merged 1 commit intohuizhougit:masterfrom
Conversation
`child_process.spawn` is generally faster than `child_process.exec` and it does not buffer the data before sending, so no buffer limits (default 200k in exec) apply.
Contributor
Author
Owner
|
Thanks for the PR @BenBeattieHood ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
child_process.spawnis generally faster thanchild_process.execand it does not buffer the data before sending, so no buffer limits (default 200k in exec) apply.