Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock environment type/id #28

Merged

Conversation

johanneswuerbach
Copy link
Contributor

Remove the ability to customize the environment / environment_type for now as things like backstage rely that k8s-cluster & k8s-namespace are matched to an environment called development https://github.com/humanitec-architecture/backstage/blob/main/.github/workflows/deploy.yaml#L139

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner June 21, 2024 10:03
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanneswuerbach johanneswuerbach merged commit 79d0102 into humanitec-architecture:main Jun 26, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the lock-env branch June 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants