feat: use resource account #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
resource-account
branch
from
08d6ac2 to
ad10a68
Compare
| @@ -12,10 +44,11 @@ module "dns_basic" { | |||
|
|
|||
| resource_packs_gcp_url = var.resource_packs_gcp_url | |||
| resource_packs_gcp_rev = var.resource_packs_gcp_rev | |||
| append_logs_to_error = true | |||
There was a problem hiding this comment.
We started to use this in Azure and it proved really valuable for debugging, so also enabling it for the examples and made it configurable for the modules.
| @@ -24,4 +57,5 @@ module "dns_basic" { | |||
| resource "humanitec_resource_definition_criteria" "dns_basic" { | |||
| resource_definition_id = module.dns_basic.id | |||
| app_id = humanitec_application.example.id | |||
| force_delete = true | |||
There was a problem hiding this comment.
The criteria always need a force_delete, otherwise you can't destroy the stack as Humanitec waits for the app to be gone, but TF waits for the criteria to be deleted 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a resource account to inject credentials instead of directly injecting them into the driver.
This will allow us to use temporary credentials in the future.
So far the account role is fairly wide, but we can narrow it down in the future. As most resources need to provision GCP service accounts, the provisioner role needs to be always fairly powerful though.