Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IMagick with s3 compat #306

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix IMagick with s3 compat #306

merged 1 commit into from
Apr 16, 2019

Commits on Apr 8, 2019

  1. Fix IMagick with s3 compat

    In some cases (it's not that clear how) Imagick is not compatible with remote streams. According to the docs, this has never been possible, but I think it happened to work in the past. I've tried the same version of imagick, on different sets and sometimes works, some times doesnt. The crux of the issue is that IMagick tries to read from the stream, and is sending a SEEK request to something near PHP_MAX_INT, which causes memory allocation issues on our stream wrapper. It's maybe possible to work around it with a seek stream guard, but really I think that's just one of many possible issues. I think it's going to be better to let IMagick always work with local images to avoid issues.
    joehoyle committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    ef1891e View commit details
    Browse the repository at this point in the history