Fix slow call to scandir() when uploading files #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please for give me for what I have done. Fixes #373.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
|
@rmccue could I get a 👍 / 👎 today on this, as this is currently blocking some production errors. |
rmccue
requested changes
Jul 7, 2020
|
@rmccue I added support for the filter too here. |
rmccue
reviewed
Jul 7, 2020
inc/class-stream-wrapper.php
Outdated
| // | ||
| // Anyone reading this far, brace yourselves for a mighty horrible hack. | ||
| $backtrace = debug_backtrace( 0, 3 ); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection | ||
| if ( isset( $backtrace[1]['function'] ) && $backtrace[1]['function'] === 'scandir' && isset( $backtrace[2]['function'] ) && $backtrace[2]['function'] === 'wp_unique_filename' ) { |
There was a problem hiding this comment.
Does this need to bail if it hit the filter callback above, or is that already handled?
There was a problem hiding this comment.
This won't be triggered, as the backtrace doesn't reflect our own scandir call.
rmccue
approved these changes
Jul 7, 2020
joehoyle
added a commit
that referenced
this pull request
Jul 8, 2020
joehoyle
added a commit
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please for give me for what I have done.
Fixes #373.