Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first pass at Node.js docs #872

Merged
merged 4 commits into from
May 9, 2024
Merged

Add first pass at Node.js docs #872

merged 4 commits into from
May 9, 2024

Conversation

rmccue
Copy link
Member

@rmccue rmccue commented Apr 9, 2024

Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some feedback left.

Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question

@mikelittle
Copy link
Contributor

@rmccue Last question: When can this go live? Will it be after v19? Or will an announcement of node.js support be part of v19?

@rmccue
Copy link
Member Author

rmccue commented Apr 24, 2024

Should be timed to be co-incident with our pilot customer's launch.

@mikelittle
Copy link
Contributor

Cool. I'll hold off merging until then. Also gives us time to get local-server updated.

@mikelittle mikelittle marked this pull request as draft April 25, 2024 16:44
@mikelittle
Copy link
Contributor

Converted to draft, as it is not yet ready to be published.

@mikelittle mikelittle marked this pull request as ready for review May 9, 2024 10:26
Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mikelittle mikelittle merged commit eaaf584 into master May 9, 2024
2 of 3 checks passed
@mikelittle mikelittle deleted the add-nodejs-docs branch May 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants