Update phpunit and wp-phpunit packages #102
Conversation
shadyvb
force-pushed
the
product-dev/1034/update-phpunit
branch
from
cae6cd1
to
b0d4a7e
Compare
|
@roborourke I kept running into JS dep conflicts, so opted for using |
There was a problem hiding this comment.
Some of the composer.json edits don't make sense, and I'm not super clear on why any JS changes were necessary but if the dev server etc works fine still then I don't see any problem. If the GH action is using ubuntu-latest and we're not specifying the node version that might be the issue. The node version should always be pinned, and preferably the ubuntu version too to keep a consistent dev environment.
composer.json
Outdated
| "roots/wordpress": "~5.9.0", | ||
| "squizlabs/php_codesniffer": "3.5.8", | ||
| "szepeviktor/phpstan-wordpress": "0.7.1", | ||
| "vlucas/phpdotenv": "^3", | ||
| "wp-cli/db-command": "^2", | ||
| "wp-phpunit/wp-phpunit": "~5.9.0", | ||
| "wp-phpunit/wp-phpunit": "5.9.3", |
There was a problem hiding this comment.
This constraint should probably match roots/wordpress, I'm not sure why this has changed, the result is the same as the previous constraint but is now locked to that specific version.
Worth bumping to WP 6.0 as well?
There was a problem hiding this comment.
Ah, the version constraint was not intentional, should've updated but kept the tilda. Sorry. And yes we should probably upgrade to 6. Will do.
There was a problem hiding this comment.
I tried to update that package explicitly, but just forgot to add the tilda in the command.
There was a problem hiding this comment.
I'm opting to keep on 5.9.3 until WP 6.0 is properly tested. Fixed the tilda.
This avoids installing or attempting to resolve peer dependencies. See #102 (comment)
Ref humanmade/product-dev#1034