Prevent errors when wp_insert_post filters send an unexpected type #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The third argument passed along with the `wp_insert_post_data` hook can be a number of different types. This adds a type check to avoid PHP error trying to access a WP_Post object as an array.
This function also fatals if a WP_Post is passed into it. (It'd be nice to specify union types, but pre-PHP 8 that wasn't supported.)
johnbillion
requested changes
May 10, 2023
|
Thanks, I've updated the |
johnbillion
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third argument passed along with the
wp_insert_post_datahook can be a number of different types.This avoids PHP errors trying to access a WP_Post object as an array by coercing that value to an array before trying to access it.