-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use capabilities queries #93
Conversation
@shadyvb & @roborourke, I have noticed that all the checks have failed. Should I review each and fix appropriately? From what I have seen they don't appear to be directly related to the code changes made, a few are falling at "Install PHP Dependencies". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem fine, apart from lock files.
- I can see composer lock file includes more changes that might not be needed ( eg: coding standards version update ), so wondering how the WordPress update was carried out.
- Is the packages lock file update expected ? seems like quite a bit of changes.
Also, do we need to update the reference at https://github.com/humanmade/authorship/blob/develop/.github/workflows/test.yml#L17 ?
Also we do need to fix the CI before merging. I can see it's the composer version that might need to be updated.
…e-capabilities-param
Hey @shadyvb Thanks for the review and direction (slack thread). I have updated the PR. I have one check failing, is this the same as what you referenced in your review earlier? |
WP 5.9 includes new capabilities user queries that replace the role based
who
query parameter.This PR includes the
capabilities
query.Issue #523