Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PHP requirement to a minimum version #98

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

roborourke
Copy link
Contributor

Currently Authorship is uninstallable using composer and PHP 8.0 or higher.

I ran the PHPCS compatibility check and there are no warnings or errors for both 8.0 and 8.1.

I think this could be a patch release, as it falls more under bug territory and there are no other changes.

Currently Authorship is uninstallable using composer and PHP 8.0 or higher.

I ran the PHPCS compatibility check and there are no warnings or errors for both 8.0 and 8.1.
@roborourke
Copy link
Contributor Author

Interesting, trying it out with the tests on multiple versions indicates the presence of the committed composer.lock is not helpful if this is something we want to do 🤔

shadyvb
shadyvb previously approved these changes Apr 21, 2022
@roborourke roborourke merged commit 75cb18a into develop Apr 22, 2022
@roborourke roborourke deleted the fix-php-constraint branch April 22, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants