Audience UI

[roborourke]

Still plenty to do and questions to answer. Like should we grab the index mapping to access all the fields so we get their type, or just infer that given we know the data structure...

Fixes #19

TODO:

• Audience test endpoint
• Audience save endpoint
• Handle lack of analytics data

Potentially split these to separate PRs

• Documentation
• Handle numbers via ranges eg. gt, lt, gte, lte
• Handle wildcards / free text
• Audience post listing columns - estimate spark line / number
• Audience add/edit control & modal for block editor
• Assign endpoint to audience client side
• Provide on updateEndpoint event for external code to hook in and re-render things

[hm-linter]

Linting failed (1 error).

[roborourke]

Audience builder UI in progress.

[rmccue]

Haven't gone through the code here yet, but here's my quick notes from user testing:

• Remove button needs better styling, a bit off-centre?
  
• "equals" "Empty" is a bit unclear (could be a browser called Empty eg), should be "is empty" or "equals" "[Empty]" or similar
• The graph is super slick; we should add a loading icon after the inputs change while waiting for the data to load.
• Should we rename the "options" box to "audience estimates" to avoid the duplicative title?
• "This page is asking you to confirm that you want to leave" when clicking save
• Auto Drafts are listed in the audience table, have "Invalid parameter(s): audience". Related, clicking Trash doesn't remove it from the list; is the post status filter incorrectly selecting all statuses?
• "The response is not a valid JSON response."; empty backend response? URL is http://altis.local/wp-json/analytics/v1/audiences/estimate?audience=%7B%22include%22%3A%22all%22%2C%22groups%22%3A%5B%7B%22include%22%3A%22any%22%2C%22rules%22%3A%5B%7B%22field%22%3A%22attributes.referer%22%2C%22operator%22%3A%22%21%3D%22%7D%5D%7D%5D%7D&_locale=user
• On the update page, the value field on the first row isn't visible until you change the comparison. Here's a screen rec of the new page first (which works) and the update page (which doesn't):
  

[rmccue]

Overall, the code looks good to me.

In the JS section, there's a lot bundled into one particular component (noted in comment) that could really use with splitting out into multiple instead; both for readability, and for potential reuse in the future.

IMO, the readability of a few of these would also be enhanced by switching them to class components with methods/etc rather than functional components.

[roborourke]

Oh thank god for that. Alright, full steam ahead on XBs!