Send end trace on early shutdown #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the script execution ends before the WordPress shutdown handler has been set up, we don't sent the end trace. This is a problem because Batcache (or any advanced-cache.php) HIT will be before the shutdown handler for WordPress has been set up. We have to add our own shutdown handler in all cases, and only use it where appropriate.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
rmccue
reviewed
Mar 5, 2020
inc/namespace.php
Outdated
| // It's possible the script is shutting down before register_shutdown_function( 'shutdown_action_hook' ) | ||
| // has been called by WordPress. There's no way to check if this callback has been registered, so we use a heuristic that | ||
| // default-filters.php has not been loaded, which happens just before WordPress calls register_shutdown_function. | ||
| if ( has_action( 'wp_scheduled_delete', 'wp_scheduled_delete' ) === false ) { |
There was a problem hiding this comment.
function_exists( 'get_locale' ) would be a better heuristic; l10n.php is loaded immediately after the shutdown function.
As an alternative idea, could we call register_shutdown_function( 'shutdown_action_hook' ) ourselves? What happens when the same function is added twice?
There was a problem hiding this comment.
Yeah I didn't want to do that, as I think there might be a lot of functionality hooked into shutdown that cached-responses might not want.
Co-Authored-By: Ryan McCue <me@ryanmccue.info>
…to fix-early-shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the script execution ends before the WordPress shutdown handler has been set up, we don't sent the end trace. This is a problem because Batcache (or any advanced-cache.php) HIT will be before the shutdown handler for WordPress has been set up.
We have to add our own shutdown handler in all cases, and only use it where appropriate.