Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting stats from Afterburner #90

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

joehoyle
Copy link
Member

No description provided.

@joehoyle joehoyle requested a review from a team March 17, 2023 14:48
Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
If this is a drop in replacement for the PHP extension, is there a reason the hits and misses stats are not collected/available?

@joehoyle
Copy link
Member Author

If this is a drop in replacement for the PHP extension, is there a reason the hits and misses stats are not collected/available?

Good question, we could implement this. The object cache drop-ins are a bit all over the place in terms of what stats they collect.

@joehoyle joehoyle merged commit 02b5f87 into master Mar 21, 2023
@joehoyle joehoyle deleted the support-afterburner-stats branch March 21, 2023 11:11
@kovshenin
Copy link

For us I think it'd be useful to also know at what level the hits/misses are: runtime vs. local cache vs. remote.

@joehoyle
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants